test(s3): cover anonymous admin signing#214
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test in the rc-s3 admin client test suite to ensure that when an alias is marked anonymous, admin requests are sent without SigV4 Authorization headers (covering a previously untested branch introduced by anonymous alias support).
Changes:
- Extend the admin test server request capture to include raw request headers.
- Add a helper to construct an anonymous
AdminClientfor a given endpoint. - Add a
#[tokio::test]asserting anonymousheal_status()requests do not include anAuthorizationheader.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overtrue
force-pushed
the
test-gap-20260524
branch
from
4f478f6 to
9b2f8c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
None. Automation found a recent test gap.
Background
Recent mTLS and anonymous alias support added an admin client branch that skips SigV4 signing when an alias is anonymous. Existing admin route tests used credentialed aliases, so they did not prove anonymous admin requests omit the Authorization header.
Solution
Add a focused rc-s3 admin regression test that sends an anonymous heal status request through the local admin test server and asserts the request has no Authorization header.
Validation